Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5 more player mappings to add. #255

Merged
merged 5 commits into from
Sep 22, 2024
Merged

5 more player mappings to add. #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
456086a
3 more mappings to add.
TheMathNinja Sep 4, 2024
f004a92
adjust tests in order to fix broken Mac checks
mrcaseb Sep 4, 2024
8392115
Two more names to map.
TheMathNinja Sep 4, 2024
45b6251
Resolved merge conflict
TheMathNinja Sep 13, 2024
5e98f70
Merge branch 'main' into main
tanho63 Sep 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

- nflreadr now exports the variable `nflreadr::nflverse_data_timezone` which defines the standard timezone
across all nflverse data. When printing to the console, nflreadr will convert timestamps to the user local timezone.
- Added several player name mappings (#249, #253)
- Added several player name mappings (#249, #253, #255)
- Added a dictionary to describe what each shorthand roster status indicates (#232)

---
Expand Down
5 changes: 5 additions & 0 deletions data-raw/clean_player_names.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,3 +130,8 @@ DeVon Achane,Devon Achane
Demario Douglas,DeMario Douglas
Michael Hall,Mike Hall
Andru Phillips,Dru Phillips
Alexander Johnson,AJ Johnson
Matt Ioannidis,Matthew Ioannidis
Cobie Durant,Decobie Durant
Chris Smith,Christopher Smith
Grant DuBose,Grant Dubose
Binary file modified data/player_name_mapping.rda
View file
Open in desktop
Binary file not shown.
Loading