Merge branch 'main' into roster-status-dict

nflverse · Aug 27, 2024 · 7c8fb59 · 7c8fb59
2 parents 9d3b7c3 + 8a943b3
commit 7c8fb59
Show file tree

Hide file tree

Showing 30 changed files with 60 additions and 7 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: nflreadr
 Title: Download 'nflverse' Data
-Version: 1.4.1.00
+Version: 1.4.1.02
 Authors@R: c(
     person("Tan", "Ho", , "[email protected]", role = c("aut", "cre", "cph"),
            comment = c(ORCID = "0000-0001-8388-5155")),
@@ -49,4 +49,4 @@ Config/testthat/edition: 3
 Encoding: UTF-8
 LazyData: true
 Roxygen: list(markdown = TRUE)
-RoxygenNote: 7.2.3
+RoxygenNote: 7.3.2
diff --git a/NEWS.md b/NEWS.md
@@ -1,6 +1,8 @@
 # nflreadr (development version)
 
-
+- nflreadr now exports the variable `nflreadr::nflverse_data_timezone` which defines the standard timezone
+across all nflverse data. When printing to the console, nflreadr will convert timestamps to the user local timezone.
+- Added several player name mappings (#249, #253)
 
 ---
 

diff --git a/R/data.R b/R/data.R
@@ -206,3 +206,9 @@
 #'   \item{value attribute}{The "correct" name.}
 #' }
 "team_abbr_mapping_norelocate"
+
+#' nflverse Timezone
+#'
+#' A character string defining the default timezone for data across the nflverse
+#'
+"nflverse_data_timezone"
diff --git a/R/utils_nflverse_data_class.R b/R/utils_nflverse_data_class.R
@@ -16,9 +16,15 @@ print.nflverse_data <- function(x,...){
   cli::cli_rule("{.emph nflverse {attr(x,'nflverse_type')}}")
 
   if(!is.null(attr(x,'nflverse_timestamp'))) {
-    cli::cli_alert_info(
-      "Data updated: {.field {format(attr(x,'nflverse_timestamp'), tz = Sys.timezone(), usetz = TRUE)}}"
+    # Print a formatted string in local timezone
+    timestamp <- format(
+      # the attribute is character so we have to convert it to POSIX to be able
+      # to convert the timezone to the local one
+      as.POSIXct(attr(x,'nflverse_timestamp'), tz = nflreadr::nflverse_data_timezone),
+      tz = Sys.timezone(),
+      usetz = TRUE
     )
+    cli::cli_alert_info("Data updated: {.field {timestamp}}")
   }
 
   NextMethod(print,x)
@@ -45,7 +51,7 @@ as.nflverse_data <- function(df, nflverse_type = NULL, ...){
     (length(dots) > 0 | !is.null(nflverse_type)) &&
     is.null(attr(df, "nflverse_timestamp"))
   ){
-    data.table::setattr(df, "nflverse_timestamp", Sys.time())
+    data.table::setattr(df, "nflverse_timestamp", format(Sys.time(), tz = nflreadr::nflverse_data_timezone, usetz = TRUE))
   }
 
   return(df)

diff --git a/data-raw/clean_player_names.csv b/data-raw/clean_player_names.csv
@@ -109,4 +109,24 @@ Janoris Jenkins,Jackrabbit Jenkins
 Deonte Harty,Deonte Harris
 Shaquille Leonard,Darius Leonard
 Robbie Anderson,Robby Anderson
-Tank Dell,Nathaniel Dell
+Tank Dell,Nathaniel Dell
+Julius Brents,JuJu Brents
+Tariq Woolen,Riq Woolen
+Jartavius Martin,Quan Martin
+Marquise Brown,Hollywood Brown
+YaYa Diaby,Yaya Diaby
+Michael Danna,Mike Danna
+Ogbonnia Okoronkwo,Ogbo Okoronkwo
+Cedrick Wilson,Ced Wilson
+Josh Uche,Joshua Uche
+Patrick Jones,Pat Jones
+Adetokunbo Ogundeji,Ade Ogundeji
+Daxton Hill,Dax Hill
+Zachary Carter,Zach Carter
+Chigoziem Okonkwo,Chig Okonkwo
+Andrew Ogletree,Drew Ogletree
+Nate Landman,Nathan Landman
+DeVon Achane,Devon Achane
+Demario Douglas,DeMario Douglas
+Michael Hall,Mike Hall
+Andru Phillips,Dru Phillips
diff --git a/data-raw/nflverse_data_timezone.R b/data-raw/nflverse_data_timezone.R
@@ -0,0 +1,2 @@
+nflverse_data_timezone <- "America/Toronto"
+usethis::use_data(nflverse_data_timezone, overwrite = TRUE)
diff --git a/data/dictionary_combine.rda b/data/dictionary_combine.rda
diff --git a/data/dictionary_contracts.rda b/data/dictionary_contracts.rda
diff --git a/data/dictionary_depth_charts.rda b/data/dictionary_depth_charts.rda
diff --git a/data/dictionary_draft_picks.rda b/data/dictionary_draft_picks.rda
diff --git a/data/dictionary_espn_qbr.rda b/data/dictionary_espn_qbr.rda
diff --git a/data/dictionary_ff_opportunity.rda b/data/dictionary_ff_opportunity.rda
diff --git a/data/dictionary_ff_playerids.rda b/data/dictionary_ff_playerids.rda
diff --git a/data/dictionary_ff_rankings.rda b/data/dictionary_ff_rankings.rda
diff --git a/data/dictionary_ftn_charting.rda b/data/dictionary_ftn_charting.rda
diff --git a/data/dictionary_injuries.rda b/data/dictionary_injuries.rda
diff --git a/data/dictionary_nextgen_stats.rda b/data/dictionary_nextgen_stats.rda
diff --git a/data/dictionary_participation.rda b/data/dictionary_participation.rda
diff --git a/data/dictionary_pfr_passing.rda b/data/dictionary_pfr_passing.rda
diff --git a/data/dictionary_player_stats.rda b/data/dictionary_player_stats.rda
diff --git a/data/dictionary_rosters.rda b/data/dictionary_rosters.rda
diff --git a/data/dictionary_schedules.rda b/data/dictionary_schedules.rda
diff --git a/data/dictionary_snap_counts.rda b/data/dictionary_snap_counts.rda
diff --git a/data/dictionary_trades.rda b/data/dictionary_trades.rda
diff --git a/data/nflverse_data_timezone.rda b/data/nflverse_data_timezone.rda
diff --git a/data/player_name_mapping.rda b/data/player_name_mapping.rda
diff --git a/data/team_abbr_mapping.rda b/data/team_abbr_mapping.rda
diff --git a/data/team_abbr_mapping_norelocate.rda b/data/team_abbr_mapping_norelocate.rda
diff --git a/man/nflverse_data_timezone.Rd b/man/nflverse_data_timezone.Rd
diff --git a/pkgdown/_pkgdown.yml b/pkgdown/_pkgdown.yml
@@ -27,6 +27,7 @@ reference:
   - "load_ftn_charting"
   - "nflverse_download"
   - "nflverse_releases"
+  - "nflverse_data_timezone"
 - title: Load ffverse data
   contents:
   - "load_ff_playerids"