feat(monitor-data-status): Add Slack notifications and update README.md #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Integrated Slack notifications for success and failure cases - Updated README.md to include instructions for running the job - Need testing dataset to confirm functionality...
anngvu
requested changes
Dec 20, 2024
| print(f"Project {project_to_update['name']} had dataStatus changed to 'Under Embargo'") | ||
|
|
||
| # Notify Slack of success | ||
| slack_report(slack, success=True, job_schedule=job_schedule, job_label=job_label, target="update_data_status") |
There was a problem hiding this comment.
It would be more helpful if the target reported meant number of target projects successfully updated. So a notification message like:
✅ - weekly - monitor-data-status succeeded, 3 projects were updated, instead of target="update_data_status", which is not as informative. On some weeks, it might be 0 projects targeted (because 0 qualified), which is fine.
| # print(f"Targets: {targets}") | ||
|
|
||
|
|
||
| # # Constants for the views |
There was a problem hiding this comment.
You can remove the old code instead of keeping it as commented-out section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@anngvu Can you test/review the code or suggest some test datasets that maybe appropiate for this feature? Thanks!