Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort the installed_by list in modules.json #2570

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

mirpedrol
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@maxulysse
Copy link
Member

Finally <3

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (40ee3b2) 74.96% compared to head (ebf162f) 75.03%.
Report is 7 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2570      +/-   ##
==========================================
+ Coverage   74.96%   75.03%   +0.07%     
==========================================
  Files          85       85              
  Lines        9306     9306              
==========================================
+ Hits         6976     6983       +7     
+ Misses       2330     2323       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirpedrol mirpedrol merged commit d1994a7 into nf-core:dev Dec 14, 2023
20 checks passed
@mirpedrol mirpedrol deleted the sort-modules-json-list branch December 14, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants