Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain tags in subworkflows aren't parsed correctly while linting #2555

Closed
adamrtalbot opened this issue Dec 6, 2023 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@adamrtalbot
Copy link
Contributor

Description of the bug

For UTILS_NFVALIDATION_PLUGIN, I had to add the following tags to get the nf-core linting to get it to pass:

    tag "plugin/nf-validation"
    tag "'plugin/nf-validation'"

If I didn't include the double quoted tag it didn't like it.

Command used and terminal output

nf-core --verbose subworkflows lint utils_nfvalidation_plugin

│ utils_nfvalidation_plugin  │ subworkflows/nf-core/utils_nfvalidation_plugin/tests/main.nf.test │ Tags do not adhere to guidelines. Tags missing in main.nf.test:          │
│                            │                                                                   │ ["'plugin/nf-validation'"]

System information

No response

@adamrtalbot adamrtalbot added the bug Something isn't working label Dec 6, 2023
mashehu added a commit to mashehu/tools that referenced this issue Dec 6, 2023
@GallVp
Copy link
Member

GallVp commented Dec 6, 2023

For one of my local workflows, I had to add a single quote at the end, inside double quote as in "gt/gff3validator'" to pass the lint.

@mashehu
Copy link
Contributor

mashehu commented Dec 7, 2023

fixed in #2558

@mashehu mashehu closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants