Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix swf test error #2546

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Fix swf test error #2546

merged 4 commits into from
Nov 29, 2023

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Nov 28, 2023 •
edited
Loading

mirpedrol
mirpedrol approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov Codecov
Copy link

codecov bot commented Nov 28, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1ad27a7) 74.93% compared to head (13bbac6) 74.94%.
Report is 1 commits behind head on dev.

❗ Current head 13bbac6 differs from pull request most recent head 4356351. Consider uploading reports for the commit 4356351 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #2546   +/-   ##
=======================================
  Coverage   74.93%   74.94%           
=======================================
  Files          85       85           
  Lines        9215     9214    -1     
=======================================
  Hits         6905     6905           
+ Misses       2310     2309    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mashehu mashehu merged commit 7f869b1 into nf-core:dev Nov 29, 2023
19 checks passed
@mashehu mashehu deleted the fix-swf-linting-error branch November 29, 2023 11:05
@mashehu mashehu mentioned this pull request Nov 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mashehu @mirpedrol