-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a feature to generate samplesheet for differentialabundance #546
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor commetns after a quick skim
conf/modules.config
Outdated
mode: params.publish_dir_mode, | ||
pattern: '*.{tsv,csv,arrow,parquet,biom}' | ||
], | ||
[ path: { "${params.outdir}/downstream_samplesheets/differentialabundance/"}, | ||
mode: params.publish_dir_mode, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should only be enabled if the --generate_samplesheet_xxxx
parameters are used!
- `samplesheet.csv`: A samplesheet for each classifier. | ||
- `matrix.csv`: The output from taxpasta. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should copy here also the note beflow about hte missing conditions
|
||
ch_colnames = Channel.of('sample') | ||
|
||
channelToSamplesheet(ch_colnames, ch_list_for_samplesheet, "downstream_samplesheets/differentialabundance", "samplesheet_${samplesheet_name}" ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the latest function as in detaxizer! It's tweaked again (sorry about that!)
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).