small refactor + adding intervals #34
Conversation
| versions = versions.mix(GATK4_CREATESEQUENCEDICTIONARY.out.versions) | ||
| } | ||
| // the whole map -> null should be removed once I managed to make it work properly | ||
| BWAMEM1_INDEX( |
There was a problem hiding this comment.
This is a really nice way to skip the repeated if statement.
On the other hand this will pollute the output nextflow log with empty processes...
Is it okay for you ?
There was a problem hiding this comment.
that's fine for now, I'll deal with this later if it's really an issue, but for now, I just want a code that is cleaner to read
There was a problem hiding this comment.
In phaseimpute we also have this issue with branching event, but nothing can be done.
|
|
||
| if (tools && tools.split(',').contains('gffread')) { | ||
| if (tools.contains('gffread')) { | ||
| GFFREAD(input.gff, []) |
There was a problem hiding this comment.
Why didn't you continue with the simplification of the if statements ?
There was a problem hiding this comment.
Just testing it out on some processes, I didn't want to modify everything in one go as I just wanted to tackle intervals on this PR.
There was a problem hiding this comment.
That does make sense.
Could you open an issue in this case in the repository to have a follow up for standardization ?
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).