Merge pull request #39 from haltuf/master

fix compatibility with PHP < 8
nextras · Dec 7, 2022 · 49ffce9 · 49ffce9
2 parents 63c7481 + 752ad93
commit 49ffce9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/SecuredLinksPresenterTrait.php b/src/SecuredLinksPresenterTrait.php
@@ -68,7 +68,10 @@ public function createSecuredLink(Component $component, string $link, string $de
 			$method = $component->formatSignalMethod($signal);
 			$signalReflection = $reflection->getMethod($method);
 
-			if (!$signalReflection->hasAnnotation('secured') && count($signalReflection->getAttributes(Secured::class)) === 0) {
+			if (!$signalReflection->hasAnnotation('secured')) {
+				break;
+			}
+			if (method_exists($signalReflection, 'getAttributes') && count($signalReflection->getAttributes(Secured::class)) === 0) {
 				break;
 			}
 

diff --git a/tests/cases/SecuredLinksTest.php7.phpt b/tests/cases/SecuredLinksTest.php7.phpt
@@ -33,6 +33,10 @@ class TestPresenter extends Presenter
 		$this->redirect('this');
 	}
 
+	public function handleCancel(bool $value)
+	{
+		$this->redirect('this');
+	}
 }
 
 
@@ -57,6 +61,7 @@ $presenter->injectPrimary(NULL, NULL, $router, $httpRequest, $httpResponse, $ses
 $presenter->run($request);
 
 Assert::same('/index.php?value=0&action=default&do=pay&presenter=Test&_sec=JqCasYHU', $presenter->link('pay!', [FALSE]));
+Assert::same('/index.php?value=0&action=default&do=cancel&presenter=Test', $presenter->link('cancel!', [FALSE]));
 
 $presenter->run(new Request('Test', 'GET', [
 	'action' => 'default',