Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two-phase SQL rewrites #687

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Two-phase SQL rewrites #687

merged 3 commits into from
Oct 31, 2024

Conversation

hrach
Copy link
Member

@hrach hrach commented Oct 29, 2024 •
edited
Loading

It's kinda funny how this change looks simple. It took me 5 hours to come up with it
🤯💥🤯💥🤯💥🤯💥🤯💥🤯💥

@hrach hrach linked an issue Oct 29, 2024 that may be closed by this pull request
Performance issues in simpley ANY queries with or. #686
Closed
@hrach hrach self-assigned this Oct 29, 2024
@hrach hrach added this to the v5.0 milestone Oct 29, 2024
@hrach hrach force-pushed the rewrites-two-phase branch from 4402b54 to dedc0ba Compare October 29, 2024 22:33
@hrach hrach mentioned this pull request Oct 30, 2024
Merged
@hrach hrach force-pushed the rewrites-two-phase branch from dedc0ba to ee8b661 Compare October 30, 2024 20:02
@hrach hrach linked an issue Oct 30, 2024 that may be closed by this pull request
Missing primary filter lifting to HAVING clause #690
Closed
@hrach hrach mentioned this pull request Oct 30, 2024
Closed
@hrach hrach force-pushed the rewrites-two-phase branch from ee8b661 to a026c48 Compare October 31, 2024 10:29
@hrach
rework collection functions to utilize two-phase expression processing
ad6dfe0 
To provide more smarted SQL rewrites, we need to know if the expression
itself is in AND/OR junction and if other parts of the junction
require a HAVING clause. This is possible only after getting the full
expression tree. Then we collect the actual expressions.

[closes #690]
[closes #686]
@hrach hrach force-pushed the rewrites-two-phase branch from a026c48 to ad6dfe0 Compare October 31, 2024 10:35
@hrach hrach merged commit 43e6322 into main Oct 31, 2024
8 checks passed
@hrach hrach deleted the rewrites-two-phase branch October 31, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepapo stepapo stepapo left review comments

Assignees

@hrach hrach

Labels
None yet
Projects
None yet
Milestone
v5.0
Development

Successfully merging this pull request may close these issues.

Missing primary filter lifting to HAVING clause Performance issues in simpley ANY queries with or.
2 participants
@hrach @stepapo