Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #461

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix typos #461

wants to merge 1 commit into from

Conversation

cnpryer
Copy link

@cnpryer cnpryer commented Nov 3, 2024

These corrections are only in comments, but I ran typos-cli on the repository because of Tresholds ("thresholds").

sdk/golden/config.go

Lines 115 to 132 in 9fe2ea1

// Tresholds by data type to be used when comparing actual and expected. If the
// absolute difference between the two values is less than or equal to the
// given threshold, then we consider the two values to be equal.
type Tresholds struct {
// Float is the threshold to be used when comparing floats.
Float float64
// Int is the threshold to be used when comparing ints.
Int int
// Time is the threshold to be used when comparing times. Two times are
// considered the same if the absolute difference between them, which is a
// duration, is less than or equal to the given threshold.
Time time.Duration
// Duration is the threshold to be used when comparing durations.
Duration time.Duration
// CustomThresholds defines threshold for specific keys that override the
// generic thresholds.
CustomThresholds CustomThresholds
}

I figured since that'd be a breaking change I wouldn't include it in this PR, but at least I'd point it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant