Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clientoken #24

Merged
merged 4 commits into from
Mar 3, 2024
Merged

Add clientoken #24

merged 4 commits into from
Mar 3, 2024

Conversation

jagedn
Copy link
Collaborator

@jagedn jagedn commented Mar 2, 2024

closes #23

during the refactor we removed the use of the token. This PR use the configured token to secure api calls

@jagedn jagedn requested a review from abhi18av March 2, 2024 11:08
@jagedn jagedn self-assigned this Mar 2, 2024
abhi18av
abhi18av approved these changes Mar 3, 2024
View reviewed changes
Copy link
Member

@abhi18av abhi18av left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this after resolving merge conflicts and local testing on our sun-nomadlab cluster.

Thanks @jagedn 😊

@abhi18av abhi18av merged commit bcad43e into master Mar 3, 2024
@abhi18av abhi18av linked an issue Mar 8, 2024 that may be closed by this pull request
Plugin design - dev meetings. #5
Open
16 tasks
@abhi18av abhi18av deleted the add-clientoken branch March 8, 2024 12:16
@abhi18av abhi18av mentioned this pull request Mar 9, 2024
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhi18av abhi18av abhi18av approved these changes

Assignees

@jagedn jagedn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin design - dev meetings. Add clientToken
2 participants
@jagedn @abhi18av