Make the plugin functional #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add build workflow
This reverts commit 6a53a02.
Add release workflow
Pin java version to 17
Ci - fix java version env variable
…hub action variables
… job to build and upload artifact and relase new version
CI - update release system
CI - add GitHub token
Remove override of start and stop methods from BasePlugin
Upgrade kafka-clients to 3.7.1
…ion if mandatory paramteres (url and group) aren't set
Fix reading from topics
Fix watch topic
|
Hi @pditommaso, is the maintainer of this plugin still among you ? If not, it will be possible that someone from nextflow review this PR ? Best, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR change:
github workflowto build on every push on dev branchesgithub workflowto build and upload artifacts and release a new version on a tag pushgradletasks to upload usinggithub actionvariablespublishIndextaskoverrideofstartmethods inKafkaPluginpollTimeoutconfkafka-clientsto3.7.1fromTopicandwatchTopicfromDataflowWriteChanneltoDataflowBroadcastThis version should be released as pre-release because it needs to be tested further.
Can you take a look, please?
Keep me updated :)
Panaxging