feat: Migrate to files:node:updated #6427
Conversation
luka-nextcloud
requested review from
max-nextcloud and
mejo-
as code owners
|
@luka-nextcloud what's the background for this change? Does it fix anything? Is it a technical dept thing? |
Sorry for not mentioning. This is a technical debt, I've added the issue on the description. |
|
Thanks for the additional context @luka-nextcloud. Do you know what the emitted event is supposed to do? I.e. is there a reproducer of how to test whether this works? |
|
@mejo- The emitted event is supposed to notify the other apps that a file was updated. Install text app and notes app (with this PR nextcloud/notes#1377) then open notes app to edit a note. |
luka-nextcloud
force-pushed
the
migrate-node-update-event
branch
from
14bedd0
to
5198716
Compare
luka-nextcloud
force-pushed
the
migrate-node-update-event
branch
from
5198716
to
ae00549
Compare
juliusknorr
force-pushed
the
migrate-node-update-event
branch
from
ae00549
to
c85d586
Compare
|
Was just reported as an issue so this likely fixes #6671 |
|
Signed-off-by: Luka Trovic <[email protected]>
luka-nextcloud
force-pushed
the
migrate-node-update-event
branch
from
c85d586
to
5d8984e
Compare
| source: generateRemoteUrl(`dav/files/${this.currentSession.userId}${this.relativePath}`), | ||
| mtime: new Date(), | ||
| mime: this.mime, |
There was a problem hiding this comment.
@luka-nextcloud Can you explain why we need to also emit source and mime here? I fear source could break that way if we are using text on a public share link.
There was a problem hiding this comment.
@juliusknorr I have just checked again, source and mime are mandatory.
There was a problem hiding this comment.
📝 Summary
🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)