Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cy): rely on @nextcloud/axios for requests #5727

Merged
merged 3 commits into from
May 2, 2024

Conversation

max-nextcloud
Copy link
Collaborator

Simplify the handling of csrf-tokens and auth.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Simplifying tests.
  • No documentation needed.

@max-nextcloud max-nextcloud added tests If you write them we ♥ you 3. to review labels Apr 25, 2024
@max-nextcloud max-nextcloud force-pushed the test/simplify-cypress-requests branch 2 times, most recently from 2902033 to 5db6712 Compare April 25, 2024 07:02
@max-nextcloud

This comment was marked as resolved.

@max-nextcloud max-nextcloud force-pushed the test/simplify-cypress-requests branch 3 times, most recently from 4cc24c2 to e1baf67 Compare April 26, 2024 05:52
@max-nextcloud max-nextcloud marked this pull request as draft April 26, 2024 12:02
@max-nextcloud

This comment was marked as resolved.

@max-nextcloud max-nextcloud force-pushed the test/simplify-cypress-requests branch from e1baf67 to 4d1a54c Compare May 1, 2024 09:10
This greatly simplifies the handling of csrf-tokens and auth.

Signed-off-by: Max <[email protected]>
@max-nextcloud max-nextcloud force-pushed the test/simplify-cypress-requests branch from 4d1a54c to 62ecdf6 Compare May 2, 2024 04:31
Extract function `enterContentAndClose()`.

Signed-off-by: Max <[email protected]>
@max-nextcloud max-nextcloud marked this pull request as ready for review May 2, 2024 05:05
@juliusknorr
Copy link
Member

Very nice cleanup 🚀

@juliusknorr juliusknorr merged commit 005fc2d into main May 2, 2024
62 checks passed
@juliusknorr juliusknorr deleted the test/simplify-cypress-requests branch May 2, 2024 19:08
@mejo-
Copy link
Member

mejo- commented May 28, 2024

/backport to stable29

@mejo-
Copy link
Member

mejo- commented May 28, 2024

/backport to stable28

@mejo-
Copy link
Member

mejo- commented May 28, 2024

/backport to stable29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review tests If you write them we ♥ you
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants