Merge pull request #1918 from nextcloud/follow-up-to-1916 #3191
IvansssAnnotations
10 warnings
|
SwiftLint:
ShareExtension/ShareConfirmationViewController.swift#L558
Todo Violation: TODOs should be resolved (This has no effect on ShareExt...) (todo)
|
|
SwiftLint:
ShareExtension/ShareConfirmationViewController.swift#L610
Todo Violation: TODOs should be resolved (Do error reporting per item) (todo)
|
|
SwiftLint:
NextcloudTalkTests/Integration/Helpers.swift#L12
Todo Violation: TODOs should be resolved (This should probably be part o...) (todo)
|
|
SwiftLint:
NextcloudTalkTests/UI/Helpers.swift#L102
Todo Violation: TODOs should be resolved (Find a better way to reliable ...) (todo)
|
|
SwiftLint:
NextcloudTalk/RoomCreationTableViewController.swift#L244
Cyclomatic Complexity Violation: Function should have complexity 10 or less; currently complexity is 13 (cyclomatic_complexity)
|
|
SwiftLint:
NextcloudTalk/CallViewController.swift#L1185
Control Statement Violation: `if`, `for`, `guard`, `switch`, `while`, and `catch` statements shouldn't unnecessarily wrap their conditionals or arguments in parentheses (control_statement)
|
|
SwiftLint:
NextcloudTalk/NCRoomsManagerExtensions.swift#L12
Identifier Name Violation: Variable name 'statusCodeShouldIgnoreAttemptButJoinedSuccessfully' should be between 0 and 40 characters long (identifier_name)
|
|
SwiftLint:
NextcloudTalk/UserStatusSwiftUIView.swift#L9
Duplicate Imports Violation: Imports should be unique (duplicate_imports)
|
|
SwiftLint:
NextcloudTalk/UserStatusSwiftUIView.swift#L15
File Types Order Violation: A 'main_type' should not be placed amongst the file type(s) 'supporting_type' (file_types_order)
|
|
SwiftLint:
NextcloudTalk/UserStatusSwiftUIView.swift#L56
Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
|