[stable29] Bug/48678/restore dav error response #49483
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
backportbot
bot
requested review from
ChristophWurst,
miaulalala and
kesselb
kesselb
force-pushed
the
backport/49004/stable29
branch
from
c7d77cc
to
2ba73b4
Compare
|
Conflicts: Constructor property promotion and Imports in Server and ServerFactory |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $error->setAttribute('xmlns:s', self::NS_SABREDAV); | ||
| $DOM->appendChild($error); | ||
|
|
||
| $h = function ($v) { |
Check notice
Code scanning / Psalm
MissingClosureReturnType Note
| $error->setAttribute('xmlns:s', self::NS_SABREDAV); | ||
| $DOM->appendChild($error); | ||
|
|
||
| $h = function ($v) { |
Check notice
Code scanning / Psalm
MissingClosureParamType Note
| } | ||
| class BrowserErrorPagePlugin extends ServerPlugin { | ||
| /** @var Server */ | ||
| private $server; |
Check notice
Code scanning / Psalm
MissingConstructor Note
| $this->server->httpResponse->setHeader('Content-Type', 'application/xml; charset=utf-8'); | ||
| } | ||
| public function generateBody(int $httpCode) { | ||
| $request = \OC::$server->getRequest(); |
Check notice
Code scanning / Psalm
DeprecatedMethod Note
kesselb
force-pushed
the
backport/49004/stable29
branch
from
2ba73b4
to
95ea51a
Compare
miaulalala
approved these changes
Nov 26, 2024
…eption output" This reverts commit e202896. Signed-off-by: Daniel Kesselberg <[email protected]>
This reverts commit d2bf361. Signed-off-by: Daniel Kesselberg <[email protected]>
This reverts commit 9992e7d. Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
backport/49004/stable29
branch
from
95ea51a
to
e8c6d05
Compare
Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
backport/49004/stable29
branch
from
e8c6d05
to
5de28cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #49004
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.