fix(Files): use prepare statement for path_hash in propagator #49469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
added
3. to review
| @@ -80,7 +80,7 @@ public function propagateChange($internalPath, $time, $sizeDifference = 0) { | |||
| $builder->update('filecache') | |||
| ->set('mtime', $builder->func()->greatest('mtime', $builder->createNamedParameter((int)$time, IQueryBuilder::PARAM_INT))) | |||
| ->where($builder->expr()->eq('storage', $builder->createNamedParameter($storageId, IQueryBuilder::PARAM_INT))) | |||
| ->andWhere($builder->expr()->in('path_hash', $hashParams)); | |||
| ->andWhere($builder->expr()->in('path_hash', $builder->createNamedParameter($hashParams, IQueryBuilder::PARAM_STR_ARRAY))); | |||
There was a problem hiding this comment.
should then not return $builder->expr()->literal($hash); above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The other day I had to analyze SQL queries. And in the log I found entries like:
As you see, some parameters where having placeholders (originating from use of prepared statements) while the IN list had not. So it was not possible to simply sum up this query, because it contained differing values.
Checklist