fix(ocm): psalm

Signed-off-by: Maxence Lange <[email protected]>

lib/private/Security/Signature/Model/IncomingSignedRequest.php

@@ -198,18 +198,6 @@ public function getKeyId(): string {
 		return $this->getSignatureElement('keyId');
 	}
 
-	/**
-	 * @return SignatureAlgorithm
-	 * @throws SignatureElementNotFoundException
-	 */
-	public function getUsedEncryption(): SignatureAlgorithm {
-		try {
-			return SignatureAlgorithm::from($this->getSignatureElement('algorithm'));
-		} catch (\Exception) {
-			throw new SignatureElementNotFoundException('unknown algorithm');
-		}
-	}
-
 	public function jsonSerialize(): array {
 		return array_merge(
 			parent::jsonSerialize(),

lib/private/Security/Signature/Model/OutgoingSignedRequest.php

@@ -93,12 +93,12 @@ public function getHost(): string {
 	 * @inheritDoc
 	 *
 	 * @param string $key
-	 * @param string|int|float|bool|array $value
+	 * @param string|int|float $value
 	 *
 	 * @return IOutgoingSignedRequest
 	 * @since 31.0.0
 	 */
-	public function addHeader(string $key, string|int|float|bool $value): IOutgoingSignedRequest {
+	public function addHeader(string $key, string|int|float $value): IOutgoingSignedRequest {
 		$this->headers[$key] = $value;
 		return $this;
 	}

lib/private/Security/Signature/SignatureManager.php

@@ -430,7 +430,7 @@ private function verifySignedRequest(IIncomingSignedRequest $signedRequest): voi
 				$signedRequest->getClearSignature(),
 				$signedRequest->getSignedSignature(),
 				$publicKey,
-				$signedRequest->getUsedEncryption()
+				SignatureAlgorithm::tryFrom($signedRequest->getSignatureElement('algorithm')) ?? SignatureAlgorithm::SHA256
 			);
 		} catch (InvalidSignatureException $e) {
 			$this->logger->debug('signature issue', ['signed' => $signedRequest, 'exception' => $e]);