perf: improve performance of SharedStorage::getWatcher #10837
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors | |
| # SPDX-License-Identifier: MIT | |
| name: PHPUnit files_external sFTP | |
| on: | |
| pull_request: | |
| schedule: | |
| - cron: "5 2 * * *" | |
| concurrency: | |
| group: files-external-sftp-${{ github.head_ref || github.run_id }} | |
| cancel-in-progress: true | |
| jobs: | |
| changes: | |
| runs-on: ubuntu-latest-low | |
| outputs: | |
| src: ${{ steps.changes.outputs.src}} | |
| steps: | |
| - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2 | |
| id: changes | |
| continue-on-error: true | |
| with: | |
| filters: | | |
| src: | |
| - '.github/workflows/**' | |
| - '3rdparty/**' | |
| - 'apps/files_external/**' | |
| - 'vendor/**' | |
| - 'vendor-bin/**' | |
| - 'composer.json' | |
| - 'composer.lock' | |
| - '**.php' | |
| files-external-sftp: | |
| runs-on: ubuntu-latest | |
| needs: changes | |
| if: ${{ github.repository_owner != 'nextcloud-gmbh' && needs.changes.outputs.src != 'false' }} | |
| strategy: | |
| # do not stop on another job's failure | |
| fail-fast: false | |
| matrix: | |
| php-versions: ['8.1', '8.4'] | |
| sftpd: ['openssh'] | |
| include: | |
| - php-versions: '8.1' | |
| coverage: ${{ github.event_name != 'pull_request' }} | |
| name: php${{ matrix.php-versions }}-${{ matrix.sftpd }} | |
| steps: | |
| - name: Checkout server | |
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 | |
| with: | |
| submodules: true | |
| - name: Set up sftpd | |
| run: | | |
| sudo mkdir /tmp/sftp | |
| sudo chown -R 0777 /tmp/sftp | |
| if [[ '${{ matrix.sftpd }}' == 'openssh' ]]; then docker run -p 2222:22 --name sftp -d -v /tmp/sftp:/home/test atmoz/sftp 'test:test:::data'; fi | |
| - name: Set up php ${{ matrix.php-versions }} | |
| uses: shivammathur/setup-php@c541c155eee45413f5b09a52248675b1a2575231 #v2.31.1 | |
| with: | |
| php-version: ${{ matrix.php-versions }} | |
| # https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation | |
| extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, redis, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite | |
| coverage: ${{ matrix.coverage && 'xdebug' || 'none' }} | |
| env: | |
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |
| - name: Set up Nextcloud | |
| run: | | |
| composer install | |
| mkdir data | |
| ./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password | |
| ./occ app:enable --force files_external | |
| echo "<?php return ['run' => true, 'host' => 'localhost:2222','user' => 'test','password' => 'test', 'root' => 'data'];" > apps/files_external/tests/config.sftp.php | |
| - name: PHPUnit | |
| run: composer run test:files_external -- \ | |
| apps/files_external/tests/Storage/SftpTest.php \ | |
| apps/files_external/tests/Storage/SFTP_KeyTest.php \ | |
| ${{ matrix.coverage && ' --coverage-clover ./clover.xml' || '' }} | |
| - name: Upload code coverage | |
| if: ${{ !cancelled() && matrix.coverage }} | |
| uses: codecov/[email protected] | |
| with: | |
| files: ./clover.xml | |
| flags: phpunit-files-external-sftp | |
| - name: sftpd logs | |
| if: always() | |
| run: | | |
| ls -l /tmp/sftp | |
| docker logs sftp | |
| sftp-summary: | |
| runs-on: ubuntu-latest-low | |
| needs: [changes, files-external-sftp] | |
| if: always() | |
| steps: | |
| - name: Summary status | |
| run: if ${{ needs.changes.outputs.src != 'false' && needs.files-external-sftp.result != 'success' }}; then exit 1; fi |