fix(autoconfig): Refactor DNS query for testing #9964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
added
bug
3. to review
comp:setup
ChristophWurst
requested review from
kesselb,
miaulalala and
SebastianKrupinski
|
/backport to stable3.7 |
|
/backport to stable3.6 |
|
/backport to stable2.2 |
|
/backport to stable1.15 |
|
/backport to stable1.14 |
|
/backport to stable1.11 |
miaulalala
approved these changes
Aug 5, 2024
SebastianKrupinski
approved these changes
Aug 5, 2024
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
fix/autoconfig/testable-dns-resolver
branch
from
989c6fe to
56faa48
Compare
This was referenced Aug 5, 2024
|
/backport to stable1.12 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits the DNS resolution into an isolated class so the code can be unit-tested.