Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix attachment downloadUrl in OCS getMail endpoint #9910

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Fix attachment downloadUrl in OCS getMail endpoint #9910

merged 1 commit into from
Jul 24, 2024

Conversation

julien-nc
Copy link
Member

It was always returning /ocs/v2.php because the mail.messageApi.downloadAttachment does not exist.

@julien-nc julien-nc requested a review from miaulalala July 24, 2024 08:46
miaulalala
miaulalala approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix Julien!

@miaulalala miaulalala merged commit 9b3225c into main Jul 24, 2024
27 of 28 checks passed
@miaulalala miaulalala deleted the fix/noid/ocs-message-attachment-download-url branch July 24, 2024 09:21
@miaulalala miaulalala added this to the v4.0.0 milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

Assignees
No one assigned
Labels
3. to review bug
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@julien-nc @miaulalala