Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add internal addresses #9891

Merged
merged 1 commit into from
Aug 13, 2024
Merged

feat: add internal addresses #9891

merged 1 commit into from
Aug 13, 2024

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Jul 19, 2024

  • Unit tests
  • Clean code
received composer settings modal
image image image image

@hamza221 hamza221 self-assigned this Jul 20, 2024
@hamza221 hamza221 added enhancement 3. to review skill:backend Issues and PRs that require backend development skills skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills labels Jul 20, 2024
@hamza221 hamza221 marked this pull request as ready for review July 20, 2024 12:35
@hamza221 hamza221 requested a review from ChristophWurst as a code owner July 20, 2024 12:35
This was referenced Jul 20, 2024
src/components/RecipientListItem.vue Outdated Show resolved Hide resolved
src/components/ThreadEnvelope.vue Outdated Show resolved Hide resolved
@hamza221 hamza221 requested review from st3iny and kesselb July 24, 2024 11:25
src/components/InternalAddress.vue Outdated Show resolved Hide resolved
src/components/InternalAddress.vue Outdated Show resolved Hide resolved
src/components/AppSettingsMenu.vue Outdated Show resolved Hide resolved
src/components/InternalAddress.vue Outdated Show resolved Hide resolved
src/components/InternalAddress.vue Show resolved Hide resolved
src/components/ThreadEnvelope.vue Outdated Show resolved Hide resolved
templates/index.php Outdated Show resolved Hide resolved
@hamza221 hamza221 force-pushed the feat/trusted-senders branch from 8a4c5bf to 1fd69b8 Compare August 12, 2024 14:33
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far!

lib/Controller/InternalAddressController.php Show resolved Hide resolved
lib/Controller/InternalAddressController.php Show resolved Hide resolved
lib/Controller/InternalAddressController.php Show resolved Hide resolved
lib/Controller/InternalAddressController.php Outdated Show resolved Hide resolved
lib/Controller/PageController.php Show resolved Hide resolved
lib/Db/InternalAddressMapper.php Outdated Show resolved Hide resolved
lib/Db/InternalAddressMapper.php Outdated Show resolved Hide resolved
Signed-off-by: Hamza Mahjoubi <[email protected]>
@hamza221 hamza221 force-pushed the feat/trusted-senders branch from 9ec9b42 to aab2db9 Compare August 13, 2024 10:40
@hamza221 hamza221 merged commit 649f29e into main Aug 13, 2024
28 of 29 checks passed
@hamza221 hamza221 deleted the feat/trusted-senders branch August 13, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement skill:backend Issues and PRs that require backend development skills skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants