-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: follow up reminders #9567
Conversation
4e4f604
to
1730950
Compare
1730950
to
e74b41a
Compare
} | ||
|
||
$this->logger->debug('Message requires follow-up: ' . $message->getId()); | ||
$tag = $this->mailManager->createTag('Follow up', '#d77000', $userId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we discussed before but there is no way to localize this because the label value is equal to it's displayed text, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessarily. The createTag()
method generates a label's value from its display text. Currently, there is no way to specify display name and label value at the same time using this method. I could adjust the API though, e.g. another optional parameter with the label value/id.
The label is localized in the frontend (if the user didn't rename it manually).
The reminder is probably hidden in the frontend and will be shown after 4 days. I added some instructions to the PR's description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8bdeb84
to
cf97ecb
Compare
I lowered the severity of the disable reminder button and moved the follow up button to the bottom. It will now properly replace the reply button. The screenshots in the description are up to date. |
cf97ecb
to
2f2d1df
Compare
Signed-off-by: Richard Steinmetz <[email protected]>
If the number of available envelopes is lower than the initial page size, the list will still be expanded without any effect. Only the second click will trigger loading more envelopes. Signed-off-by: Richard Steinmetz <[email protected]>
2f2d1df
to
b57eec0
Compare
Implements #3996
Diff is containing a lot of tests.
Testing
Architecture
Admins can disable LLM related features completely in the admin/groupware settings section. User can opt-out of this feature through the mail settings modal (bottom left one). It is enabled by default.
The feature will only be applied to new sent emails and not to existing ones. Adding a new account or resetting the cache of the sent mailbox will only trigger the feature for emails not older than 14 days to prevent a job spam.
Classifier Listener
Classifier Job
$follow_up
to notify the frontend.Frontend
Screenshots