Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable3.6] revert(outbox): catch failed SENT copy operation #9564

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

ChristophWurst
Copy link
Member

Reverts #9542

The change sends outbox messages over and over. This needs to be removed from the current pre-releases until we have a full fix.

Comment on lines +46 to +52
$localMessagesTable = $schema->getTable('mail_local_messages');
if ($localMessagesTable->hasColumn('status')) {
$localMessagesTable->dropColumn('status');
}
if ($localMessagesTable->hasColumn('raw')) {
$localMessagesTable->dropColumn('raw');
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is "new" on top of the git revert to undo the schema schanges

@ChristophWurst
Copy link
Member Author

Tested

  • Sending a successful email – Works ✔️
  • Having an erroneous email in the outbox – One attempt, no retry ✔️

@ChristophWurst ChristophWurst force-pushed the revert-9542-backport/9364/stable3.6 branch from aeda8b1 to 5980dc4 Compare April 12, 2024 18:17
@ChristophWurst ChristophWurst changed the title Revert "[stable3.6] fix(outbox): catch failed SENT copy operation" [stable3.6] revert(outbox): catch failed SENT copy operation Apr 12, 2024
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:

  • Sending a message
  • Sending a message with SMTP error
  • No retry on the errored message
  • Manual resend

@ChristophWurst ChristophWurst merged commit 5b9c7b4 into stable3.6 Apr 15, 2024
37 of 38 checks passed
@ChristophWurst ChristophWurst deleted the revert-9542-backport/9364/stable3.6 branch April 15, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants