Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset additional background styles from toolbar in CKEditor #9504

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Reset additional background styles from toolbar in CKEditor #9504

merged 1 commit into from
Apr 3, 2024

Conversation

JuliaKirschenheuter
Copy link
Contributor

Fixes #9489

Revert background styles from #9469

🏚️ Before 🏡 After
image Screenshot from 2024-03-28 16-46-10

@hamza221 is it ok in your eyes?

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Mar 28, 2024
@JuliaKirschenheuter JuliaKirschenheuter requested review from hamza221, GretaD and ChristophWurst and removed request for ChristophWurst March 28, 2024 16:00
@hamza221
Copy link
Contributor

breaks #9463

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/9489-Editor_toolbar_not_usable_with_dark_theme branch from c1ce29b to f7bf244 Compare April 2, 2024 14:01
@ChristophWurst ChristophWurst force-pushed the fix/9489-Editor_toolbar_not_usable_with_dark_theme branch from a96949c to 5039528 Compare April 3, 2024 09:17
@ChristophWurst
Copy link
Member

Rebased for #9519

@JuliaKirschenheuter JuliaKirschenheuter merged commit 498390a into main Apr 3, 2024
36 checks passed
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/9489-Editor_toolbar_not_usable_with_dark_theme branch April 3, 2024 09:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamza221 hamza221 hamza221 approved these changes

@GretaD GretaD Awaiting requested review from GretaD GretaD is a code owner

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Editor toolbar not usable with dark theme
3 participants
@JuliaKirschenheuter @hamza221 @ChristophWurst