fix(db): Avoid dirty reads while deleting messages by uid #9423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
commented
Feb 29, 2024
|
|
||
| foreach (array_chunk($uids, 1000) as $chunk) { | ||
| $messageIdQuery->setParameter('uids', $chunk, IQueryBuilder::PARAM_INT_ARRAY); | ||
| $cursor = $messageIdQuery->executeQuery(); |
There was a problem hiding this comment.
The original implementation of deleteByUid did use a sub query too: #4663. Then #4947 added an intermediate fetch. @miaulalala do you remember why this was done?
There was a problem hiding this comment.
Most likely because I ran into the usual subquery issues (where to put the brackets) and didn't know how to fix it back then.
There was a problem hiding this comment.
Good. Then this change is safe :)
6 tasks
st3iny
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was prone to dirty reads before. Now there are only write queries.
Ref nextcloud/groupware#24
How to test