Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2.2] fix(setup): Fix rate limit annotation syntax #9227

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

brad2014
Copy link
Contributor

@brad2014 brad2014 commented Jan 8, 2024

@brad2014
Copy link
Contributor Author

brad2014 commented Jan 8, 2024

@ChristophWurst The 2.2 branch has @TrapError pragmas next to my change, that are not in the 3.5 branch. I don't know enough, so I didn't touch them. (So, it makes sense why the 2.2 autobackport failed).

I'd say, oh its just a change in comments, but I see that the system is parsing and "executing" comments, so a comment change is a code change. Not sure how those get tested.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. TrapError was an annotation for 2.2 and is an attribute for 3.x

@ChristophWurst ChristophWurst merged commit e9606a1 into stable2.2 Jan 8, 2024
30 checks passed
@ChristophWurst ChristophWurst deleted the fix/PR9216-stable2.2 branch January 8, 2024 14:28
Copy link

github-actions bot commented Apr 4, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants