fix(tags): Make unreadable tags readable #9116
Conversation
Signed-off-by: Christoph Wurst <[email protected]>
|
/backport to stable3.5 |
|
/backport to stable3.4 |
|
cc @meichthys if you have a setup to test changes |
|
Envelope list needs a fix, too |
|
@ChristophWurst I'd be glad test, but i've always been confused on how to test these vue changes on a live instance since i can never find the How would i go about testing this? |
|
You'll need a dev env |
|
Ok, I figured as much. I'll find some time to get one setup. I've been putting it off too long anyway. |
This comment was marked as outdated.
This comment was marked as outdated.
ChristophWurst
changed the title
Signed-off-by: Christoph Wurst <[email protected]>
|
@nimishavijay pleaes see #9116 (comment). It's now always the same tag component and therefore has consistent styling. The pill radius is taken from the css variable for consistency with the rest of Nextcloud. Tags are more compact now to improve the information density. |
|
Pill radius and height adjustment is great 🚀 I'm only not sure about the text color, the style with the colored text looked really nice! Perhaps we could use a darker version of the selected color for the text and a lighter version for the bg, what do you think? |
Do you know a way to make this work with all possible RGB colors? |
|
How about if you select a color, we use it darkened by 60% for text and lightened by 80% for bg? I used this tool to play around with it, contrast seems to be fine Default tag colors and white and black look like this:
|
like this? |
Signed-off-by: Christoph Wurst <[email protected]>
|
I tested it with the junk tag that is autogenerated. the result is the one below. The dark theme is still shown white for me. |
Make bright on white and dark on black tag labels readable.
To do
Fixes #5149