fix: add name_hash as nullable #9091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the migration on pgsql don't work. Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
commented
Nov 24, 2023
| @@ -56,6 +56,11 @@ public function changeSchema(IOutput $output, Closure $schemaClosure, array $opt | |||
| $mailboxesTable->addUniqueIndex(['account_id', 'name_hash'], $indexNew); | |||
| } | |||
|
|
|||
| $nameHashColumn = $mailboxesTable->getColumn('name_hash'); | |||
| if (!$nameHashColumn->getNotnull()) { | |||
| $nameHashColumn->setNotnull(true); | |||
There was a problem hiding this comment.
Unsure about this one.
The default is still NULL and the value is omitted on insert a not null violation is thrown.
Do we need a new default as well?
-- auto-generated definition
create table oc_mail_mailboxes
(
id serial
primary key,
name varchar(255) not null,
account_id integer not null,
attributes varchar(255) default '[]'::character varying not null,
delimiter varchar(1) default NULL::character varying,
messages integer not null,
unseen integer not null,
selectable boolean default false,
special_use varchar(255) default '[]'::character varying not null,
sync_new_lock integer,
sync_changed_lock integer,
sync_vanished_lock integer,
sync_new_token varchar(255) default NULL::character varying,
sync_changed_token varchar(255) default NULL::character varying,
sync_vanished_token varchar(255) default NULL::character varying,
sync_in_background boolean default false,
my_acls varchar(32) default NULL::character varying,
shared boolean default false,
name_hash varchar(255) default NULL::character varying not null
);
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
When we change not from not null to null here, all rows should have their name_hash filled. And for inserts we have to make sure to always write with the hash. If we insert without, there will be an error. I think that is fine and nothing we can improve.
ChristophWurst
approved these changes
Nov 24, 2023
|
/backport to stable3.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9089
Otherwise the migration on pgsql don't work.