fix(search): Limit recipient joins to their types #8959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The join for FROM should only search only search FROM recipients. * The join for TO should only search TO recipients. * Etc. Without the additional expression in the WHERE clause, all recipient types would match. Signed-off-by: Christoph Wurst <[email protected]>
|
/backport to stable3.4 |
GretaD
approved these changes
Oct 11, 2023
ChristophWurst
deleted the
fix/search/limit-recipient-joins-to-recipient-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the additional expression in the WHERE clause, all recipient types would match.
Fixes #8954
How to test
main: search results include messages where the sender is the sender, but also recipient, cc or bcc.
here: search results only show messages where the sender is the sender.