perf: Use local caches for avatars #8951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
requested review from
st3iny,
kesselb,
miaulalala and
hamza221
kesselb
approved these changes
Oct 12, 2023
miaulalala
approved these changes
Oct 12, 2023
|
I'm realizing that for provisionings it's tricky. We don't use cache as a cache but as storage with explicit clearing to propagate changes. There will be strange artifacts on distributed systems. |
24 tasks
Local caches are faster. Distributed caches are only needed if cache is used for consistency. Populating avatar/provisioning caches for each application server should be cheaper than the remote cache access for a lot of requests reading avatars. Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
perf/local-caches
branch
from
b131fb5 to
bd75d0a
Compare
ChristophWurst
changed the title
|
Provisioning cache changes undone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local caches are faster. Distributed caches are only needed if cache is used for consistency. Populating avatar/provisioning caches for each application server should be cheaper than the remote cache access for a lot of requests reading avatars and provisionings.