Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make erroneous mail accounts not selectable in composer modal #8820

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Make erroneous mail accounts not selectable in composer modal #8820

merged 1 commit into from
Sep 25, 2023

Conversation

hamza221
Copy link
Contributor

fixes #8373

@hamza221 hamza221 self-assigned this Aug 30, 2023
@hamza221 hamza221 requested a review from GretaD August 30, 2023 17:13
@hamza221
Copy link
Contributor Author

hamza221 commented Aug 30, 2023 •
edited
Loading

cc @GretaD for the NcSelect I had to change it because I needed the selectable prop

@hamza221 hamza221 requested review from st3iny and miaulalala August 31, 2023 12:53
miaulalala
miaulalala approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm didn't test

@hamza221 hamza221 force-pushed the fix/selectable-erroneous-account branch from 703f52c to dc3396b Compare September 11, 2023 19:58
@hamza221
Copy link
Contributor Author

@ChristophWurst Should I merge this?

@ChristophWurst ChristophWurst merged commit bdcc4c2 into main Sep 25, 2023
@ChristophWurst ChristophWurst deleted the fix/selectable-erroneous-account branch September 25, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst left review comments

@GretaD GretaD GretaD approved these changes

@miaulalala miaulalala miaulalala approved these changes

@st3iny st3iny Awaiting requested review from st3iny

Assignees

@hamza221 hamza221

Labels
3. to review bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Erroneous mail account is selectable in composer modal
4 participants
@hamza221 @ChristophWurst @miaulalala @GretaD