Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): bump ckeditor family (main) (major) #8642

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(deps): bump ckeditor family (main) (major) #8642

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 21, 2023 •
edited
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@ckeditor/ckeditor5-alignment (source) 37.1.0 -> 44.1.0 age adoption passing confidence
@ckeditor/ckeditor5-basic-styles (source) 37.1.0 -> 44.1.0 age adoption passing confidence
@ckeditor/ckeditor5-block-quote (source) 37.1.0 -> 44.1.0 age adoption passing confidence
@ckeditor/ckeditor5-core (source) 37.1.0 -> 44.1.0 age adoption passing confidence
@ckeditor/ckeditor5-dev-utils (source) 37.0.1 -> 43.0.1 age adoption passing confidence
@ckeditor/ckeditor5-editor-balloon (source) 37.1.0 -> 44.1.0 age adoption passing confidence
@ckeditor/ckeditor5-editor-decoupled (source) 37.1.0 -> 44.1.0 age adoption passing confidence
@ckeditor/ckeditor5-essentials (source) 37.1.0 -> 44.1.0 age adoption passing confidence
@ckeditor/ckeditor5-font (source) 37.1.0 -> 44.1.0 age adoption passing confidence
@ckeditor/ckeditor5-heading (source) 37.1.0 -> 44.1.0 age adoption passing confidence
@ckeditor/ckeditor5-image (source) 37.1.0 -> 44.1.0 age adoption passing confidence
@ckeditor/ckeditor5-link (source) 37.1.0 -> 44.1.0 age adoption passing confidence
@ckeditor/ckeditor5-list (source) 37.1.0 -> 44.1.0 age adoption passing confidence
@ckeditor/ckeditor5-mention (source) 37.1.0 -> 44.1.0 age adoption passing confidence
@ckeditor/ckeditor5-paragraph (source) 37.1.0 -> 44.1.0 age adoption passing confidence
@ckeditor/ckeditor5-remove-format (source) 37.1.0 -> 44.1.0 age adoption passing confidence
@ckeditor/ckeditor5-theme-lark (source) 37.1.0 -> 44.1.0 age adoption passing confidence
@ckeditor/ckeditor5-upload (source) 37.1.0 -> 44.1.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

Release Notes

ckeditor/ckeditor5 (@​ckeditor/ckeditor5-alignment)

v44.1.0

Compare Source

We are pleased to announce the latest CKEditor 5 release, focusing on performance enhancements and key bug fixes to improve your editing and collaboration experience.

Release Highlights
⚡ Performance enhancements: Part 3

This release introduces another set of performance related improvements, focused on faster editor initialization for huge documents. The initialization time was lowered by further 15% to 45%, depending on the tested sample.

The combined improvements introduced in recent releases amount to around 65%-80% lower loading time in total, which means the editor will load 3-5x faster. As the gain is not linear, bigger documents see even better improvement (more than 10x faster).

Moreover, all these improvements positively impact document save time (editor.getData()), which should help with autosave issues, among others.

We still actively work in this area, so you may expect even more editor load and save efficiency improvements in the upcoming releases.

🔨 Bug Fixes and improvements
  • Comments enhancements:
    • Data export options: We introduced the showCommentHighlights option in editor.getData(), that changes the comment marker conversion, allowing for styling comments in the output. Perfect for showing what was commented in Export to PDF, for example.
    • Inline mode improvements: We addressed a problem where comment annotations in inline mode did not close properly when clicking elsewhere in the content.
    • Thread management: We resolved an issue where creating a new thread was not interrupted when the corresponding marker was removed from the content, ensuring better stability during collaborative editing.
  • Revision History update:
    • Restore functionality: We disabled the ability to restore the current (edited, not saved) revision, as it represents current content, so there is nothing to restore. At the same time, using it led to some non-obvious behaviors.
  • Image handling: We resolved an issue where images in the uploading state could be deleted when dragged and dropped within the editor. Keep dragging, even when it is not there 🙈.
🎄 Happy holidays!

As the holiday season approaches, we extend our warmest wishes to our community and users. Thank you for your continued support, and we look forward to bringing you further enhancements and exciting features in the coming year.

MINOR BREAKING CHANGES ℹ️
  • utils: spliceArray now modifies the target array and does not accept a fourth (count) argument.
Features
  • comments: Introduced the showCommentHighlights option in editor.getData() method that changes the comment marker conversion and allows styling the comments in the output.
Bug fixes
  • comments: Resolved an issue where creating a new thread was not interrupted when the corresponding marker was removed from the content, for example, by another user in real-time collaboration.
  • comments: When adding a comment in inline mode, the comment annotation will now close properly if you click elsewhere in the content.
  • find-and-replace: It should be possible to search within content of inline widgets. Closes #​11162. (commit)
  • image: Copying and pasting images in the uploading state is now possible. Closes #​16967. (commit)
  • ui: Surrounding spaces are no longer added to colors produced by hex inputs. Closes #​17386. (commit)
Other changes
Released packages

Check out the Versioning policy guide for more information.

Released packages (summary)

Minor releases (contain minor breaking changes):

Other releases:

v44.0.0

Compare Source

Release Highlights

We are excited to introduce CKEditor 5 v44.0.0, a release packed with high impact updates designed to enhance your editing experience and simplify access to our premium offers. Here's what’s new:

🚀 Self-service plans: Simplified access to premium features

We are introducing flexible self-service plans that put you in control with full transparency. Now, you can:

💡 Important for current users:

If you are upgrading to v44.0.0+, ensure a smooth transition by updating your license keys in the editor, as we implemented a new format of the key. To get the new key, visit the Customer Portal. You can also refer to our license key and activation guide for help with logging in to the portal.

📣 The open-source licensing remains unchanged. However, config.licenseKey is now a required property in the editor configuration. Use 'GPL' for installations under the GPL terms. Read more in the update guide.

🔖 Bookmarks: Organize your content with ease

Say hello to Bookmarks, a long-awaited feature that simplifies content navigation within the editor. With this release, you can:

  • Add anchors as reference points within text.
  • Link to the newly created bookmarks in the editor to navigate to specific locations within complex documents, such as contracts or technical manuals.

📍 Future updates to Bookmarks and the linking experience are planned for the upcoming releases. Follow progress and share your feedback on GitHub.

⚡ Performance improvements: Faster table rendering

The current release includes another stride towards improving the performance aspect of the editor, this time focusing on how tables are handled in the content. Implemented optimizations have made table rendering 3x faster, with the average load time of a document with a very long, complex tables dropping from around 4.5 seconds to just 1.5 seconds.

MAJOR BREAKING CHANGES ℹ️
  • config.licenseKey is now a required property in the editor configuration. Use 'GPL' for installations under the GPL terms. See #​17317.
Features
Bug fixes
  • clipboard: An in-text drop of an inline object with elements inside should be possible. Closes #​16101. (commit)
  • cloud-services: Handle refresh token when editor destroyed during token fetching. Closes #​17462. (commit)
  • editor-classic: Excluded modal windows from the Classic Editor's integration between dialogs and the sticky toolbar. Closes #​17339. (commit)
  • engine: List markers should be visible after changing the list type from multi-level to numbered. Closes #​17488. (commit)
  • find-and-replace: Find and replace no longer randomly jumps to the first found item after the replace operation. Closes #​16648. (commit)
  • list: Inserting or dropping a paragraph after the end of a list should not convert the paragraph to a list item. Closes #​17224. (commit)
  • pagination: The pagination line should be rendered properly on tables. Closes ckeditor/ckeditor5#17158.
  • restricted-editing: Remove existing restricted editing markers when setting new data to prevent marker resurrection. Closes #​9646, #​16721. (commit)
  • theme-lark: Letter descenders should not be clipped in the top-level menu bar categories. Closes #​17422. (commit)
  • track-changes: Export the AttributeData, FormatData and Description typings from package.
  • ui: The menu or dropdown panels will no longer be placed in an incorrect position when a optimal position cannot be found. Closes #​17220. (commit)
  • ui: The dialog plugin should not handle Esc key press when default-prevented by the guest view. Closes #​17343. (commit)
  • upload: Editor should no longer crash when executing undo while an image is still being uploaded. (commit)
  • utils: Use binary search in insertToPriorityArray() for better performance when handling big tables. (commit)
  • utils: No longer scroll to the top of the document if pasted element is larger than scrollable editable. Closes #​17079. (commit)
Other changes

  • collaboration-core: The types of publicly exported plugins will now be correctly resolved when accessed using editor.plugins.get.

  • comments: The types of publicly exported plugins will now be correctly resolved when accessed using editor.plugins.get.

  • real-time-collaboration: Editor will be switched to read-only mode when an unrecoverable error will be returned by Cloud Services server during real-time editing.

  • real-time-collaboration: The types of publicly exported plugins will now be correctly resolved when accessed using editor.plugins.get.

  • revision-history: The types of publicly exported plugins will now be correctly resolved when accessed using editor.plugins.get.

  • track-changes: The types of publicly exported plugins will now be correctly resolved when accessed using editor.plugins.get.

  • track-changes: The descriptionFactory property will now be accessible publicly.

  • track-changes: Suggestions of the same type that are not directly next to each other will no longer be represented as one suggestion in the UI.

  • ui: Improved the performance of the BodyCollection DOM wrapper lookup by replacing document.querySelector() with a static element reference. (commit)

    Huge thanks to Ben Demboski for this contribution!

  • Changes related to the introduction of self-service channel for CKEditor 5 Premium Features. See #​17317. (commit)

  • Updated translations. (commit)

Released packages

Check out the Versioning policy guide for more information.

Released packages (summary)

New packages:

Releases containing new features:

Other releases:

Configuration

📅 Schedule: Branch creation - "before 5am on wednesday" in timezone Europe/Vienna, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested review from ChristophWurst and GretaD July 21, 2023 08:12
@ChristophWurst ChristophWurst requested review from kesselb and removed request for ChristophWurst July 21, 2023 08:12
@ChristophWurst
Copy link
Member

@kesselb this one is for you :)

@ChristophWurst
Copy link
Member

ckeditor/ckeditor5#14082

^ @jancborchardt @marcoambrosini @nimishavijay ckeditor will show a ckeditor logo with v38 and later. Would that be a problem for us design-wise?

@nimishavijay
Copy link
Member

Where is this ckeditor used? :) And do we have control over how the logo is shown?

@ChristophWurst
Copy link
Member

ChristophWurst commented Jul 21, 2023 •
edited
Loading

CKEditor is the editor we use for the body of new emails. I don't think we have direct control over where/how the logo shows but we might be able to tweak that with css. Yet that's something we have to check with the license of the editor.

@kesselb
Copy link
Contributor

kesselb commented Jul 21, 2023

And do we have control over how the logo is shown?

They provide a couple of customization options: https://ckeditor.com/docs/ckeditor5/latest/support/licensing/managing-ckeditor-logo.html#how-to-configure-the-layout-of-the-powered-by-ckeditor-logo

@kesselb
Copy link
Contributor

kesselb commented Jul 21, 2023

Signature editor:

Screenshot from 2023-07-21 12-11-03

Composer view:

Screenshot from 2023-07-21 12-12-33

@kesselb
Copy link
Contributor

kesselb commented Jul 21, 2023

As idea:

Hiding the label and changing position is possible.

ui: {
	poweredBy: {
		position: 'inside',
		side: 'right',
		label: null,
		verticalOffset: 2,
		horizontalOffset: 2
	}
}

image

image

@nimishavijay
Copy link
Member

Screenshots by @kesselb look good to me. If possible we could link the image to their website/repo. @jancborchardt is this ok with you?

@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from 6d235ba to 3bb986f Compare August 2, 2023 10:51
@renovate renovate bot changed the title fix(deps): bump ckeditor family from 37.1.0 to v38 (main) (major) fix(deps): bump ckeditor family from 37.1.0 to v39 (main) (major) Aug 2, 2023
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from 3bb986f to 61fe5ff Compare August 10, 2023 07:46
@jancborchardt
Copy link
Member

jancborchardt commented Aug 10, 2023 •
edited
Loading

Oh wow, that's sort of invasive and nerdy.

  • Is CKEditor not really open source, as in we can't hide the logo? (We can happily have a note of it in the bottom left settings.)
  • Do we have to link the logo? Bottom right is the best placement but I am worried about misclicks when sending.

@kesselb
Copy link
Contributor

kesselb commented Aug 10, 2023 •
edited
Loading

Is CKEditor not really open source, as in we can't hide the logo? (We can happily have a note of it in the bottom left settings.)

Technically, we can hide the logo.

I can't judge whether that's okay or not. The topic is also discussed at ckeditor/ckeditor5#14082 (comment) and ckeditor/ckeditor5#14314.

Do we have to link the logo? Bottom right is the best placement but I am worried about misclicks when sending.

They don't provide an option to not generate a link.

image

I moved the send button to the left. Not much better.

Screencast.from.2023-08-10.22-35-07.webm

That's super annoying. The logo is visible if you focus on the editor.
I am uncertain if that was already the case for 38 or is new in 39.

@marcoambrosini
Copy link
Member

I also think that if it's open source we should hide the logo from the composer and add attribution in the app settings. Once those settings are moved to a settings dialog this could even be a small paragraph.

@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from 61fe5ff to 305ca2e Compare September 6, 2023 10:35
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from 305ca2e to c064b22 Compare October 4, 2023 13:15
@renovate renovate bot changed the title fix(deps): bump ckeditor family from 37.1.0 to v39 (main) (major) fix(deps): bump ckeditor family from 37.1.0 to v40 (main) (major) Oct 4, 2023
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from c064b22 to eac28f3 Compare October 5, 2023 07:20
@renovate renovate bot changed the title fix(deps): bump ckeditor family from 37.1.0 to v40 (main) (major) fix(deps): bump ckeditor family (main) (major) Oct 5, 2023
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 2 times, most recently from 46df855 to c21ed19 Compare October 19, 2023 08:24
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 2 times, most recently from a115a27 to ac6eca5 Compare October 30, 2023 09:27
@renovate renovate bot requested a review from ChristophWurst as a code owner October 30, 2023 09:27
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 2 times, most recently from f8032bc to b7df988 Compare July 16, 2024 12:04
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 3 times, most recently from 9893f82 to 2a10e35 Compare July 25, 2024 09:34
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from 2a10e35 to 1d4d11b Compare July 29, 2024 10:59
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 2 times, most recently from 737ed98 to 36bfc52 Compare August 13, 2024 08:56
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 2 times, most recently from d175b1a to ad8c035 Compare September 5, 2024 10:34
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 2 times, most recently from 8b7ea29 to dc4d1f1 Compare September 13, 2024 23:13
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 3 times, most recently from 34538c0 to 2238300 Compare October 2, 2024 09:09
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from 2238300 to 90591d7 Compare October 2, 2024 12:40
@kesselb kesselb self-assigned this Oct 3, 2024
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from 90591d7 to fd4e919 Compare October 3, 2024 10:40
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from fd4e919 to 573b041 Compare October 16, 2024 11:45
@ChristophWurst
Copy link
Member

I talked with @jancborchardt about this and CKEditor is GPLv2 and our code is AGPLv3-or-later so the code bases are compatible and we are allowed to modify the editor.
As an alternative for the in-place logo we will credit CKEditor in the README.md of this repo and an "About" section of the app settings modal.

@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 2 times, most recently from bb913be to 3e22b2e Compare October 29, 2024 12:30
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from 3e22b2e to ef86e59 Compare November 6, 2024 09:31
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from ef86e59 to 1e7823a Compare November 13, 2024 13:00
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from 1e7823a to 92a081a Compare December 2, 2024 10:23
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from 92a081a to be2e24e Compare December 12, 2024 16:01
@renovate
fix(deps): bump ckeditor family
a9046c0 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from be2e24e to a9046c0 Compare December 16, 2024 08:56
@ChristophWurst ChristophWurst assigned GretaD and unassigned kesselb Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GretaD GretaD Awaiting requested review from GretaD GretaD is a code owner

@kesselb kesselb Awaiting requested review from kesselb kesselb is a code owner

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@GretaD GretaD

Labels
3. to review dependencies
Projects
💌 📅 👥 Groupware team
Status: 📄 To do
🖍 Design team
Status: 🏗️ At engineering
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ChristophWurst @nimishavijay @kesselb @jancborchardt @marcoambrosini @GretaD