Prevent causal read for outbox message and recipient inserts #6464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable1.12 |
The message and the recipients are inserted in one transaction but the recipients are read another time outside a transaction. Read-write split database clusters might not be in full sync mode and then reading the recipients gives partial or no results. The insert will assign the primary key value to the recipient entities. Therefore we can skip reading the data. Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
fix/outbox-message-insert-recipients-causal-read
branch
from
b3a0d61 to
8d49748
Compare
ChristophWurst
deleted the
fix/outbox-message-insert-recipients-causal-read
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message and the recipients are inserted in one transaction but the
recipients are read another time outside a transaction. Read-write split
database clusters might not be in full sync mode and then reading the
recipients gives partial or no results.
The insert will assign the primary key value to the recipient entities.
Therefore we can skip reading the data.
Ref nextcloud/groupware#24