Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notifications): Notifier::prepare() threw \InvalidArgumentExcepti… #10523

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix(notifications): Notifier::prepare() threw \InvalidArgumentExcepti… #10523

merged 1 commit into from
Dec 20, 2024

Conversation

nickvergessen
Copy link
Member

…on which is deprecated

If a user has any notifications this log is generated all the time:

OCA\Mail\Notification\Notifier::prepare() threw \InvalidArgumentException which is deprecated. Throw \OCP\Notification\UnknownNotificationException when the notification is not known to your notifier and otherwise handle all \InvalidArgumentException yourself

@nickvergessen nickvergessen self-assigned this Dec 20, 2024
@kesselb
Copy link
Contributor

kesselb commented Dec 20, 2024

Nice, Thank you 🙏

@kesselb
Copy link
Contributor

kesselb commented Dec 20, 2024

/backport to stable4.1

@kesselb kesselb merged commit 15cf7ab into main Dec 20, 2024
34 of 35 checks passed
@kesselb kesselb deleted the bugfix/noid/notification-handling branch December 20, 2024 15:03
@backportbot backportbot bot mentioned this pull request Dec 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

Assignees

@nickvergessen nickvergessen

Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @kesselb