chore: welcome back webpack

[hamza221]

Reverts #9757
Reverts #10403
Reverts #10341

Closes #10427
Closes #10428

[hamza221]

I'll squash and sign once approved

[GretaD]

how can i test it?

[ChristophWurst]

I've set a PR description to make the objective of this change clear.

@GretaD you should be able to use the file picker again on this branch

[kesselb]

I'm getting the error below when running npm install or npm ci:

npm error code 1
npm error path server/apps-extra/mail/node_modules/esbuild
npm error command failed
npm error command sh -c node install.js
npm error server/apps-extra/mail/node_modules/esbuild/install.js:132
npm error     throw new Error(`Expected ${JSON.stringify(versionFromPackageJSON)} but got ${JSON.stringify(stdout)}`);
npm error           ^
npm error
npm error Error: Expected "0.17.18" but got "0.21.5"
npm error     at validateBinaryVersion (server/apps-extra/mail/node_modules/esbuild/install.js:132:11)
npm error     at server/apps-extra/mail/node_modules/esbuild/install.js:285:5
npm error
npm error Node.js v20.18.1

[kesselb]

I'm able to install the dependencies with npm update.
This modifies the lockfile (e.g. lockfileVersion 2 => 3, updates a couple of dependencies).

I tested with my locally updated state:

• Building with prod, dev and watch works
• Can open the file picker in message view
• Can open the file picker in composer
• Opening the file picker trigger a request to lazy load the component
• The add mail account button trigger a request to lazy load the component
• CKEditor's toolbar is translated when using german as language¹

Footnotes

1. We have german informal (de) and german formal (de-DE). The translation only works when using the informal version. The problem seems to exist on stable3.7 too, will log a new issue... ↩

[hamza221]

Footnotes

1. We have german informal (de) and german formal (de-DE). The translation only works when using the informal version. The problem seems to exist on stable3.7 too, will log a new issue... [↩](#user-content-fnref-1-660815b2e3d298086ed630f059106c17)

maybe it's not available at the CKEditor side ? https://ckeditor.com/docs/ckeditor5/latest/getting-started/setup/ui-language.html#list-of-available-professional-translations

[kesselb]

Footnotes

1. We have german informal (de) and german formal (de-DE). The translation only works when using the informal version. The problem seems to exist on stable3.7 too, will log a new issue... [↩](#user-content-fnref-1-660815b2e3d298086ed630f059106c17)

maybe it's not available at the CKEditor side ? https://ckeditor.com/docs/ckeditor5/latest/getting-started/setup/ui-language.html#list-of-available-professional-translations

Here's the issue: #10488

[kesselb]

Thanks for your quick fix 👍

Seems to work with your latest commit 🙏

[ChristophWurst]

I have reviewed all 24812 changed lines. Looks good

[ChristophWurst]

/backport to stable4.1