-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate the main mail store to Pinia #10138
Open
GVodyanov
wants to merge
27
commits into
main
Choose a base branch
from
feat/migrate-main-store-pinia
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigory Vodyanov <[email protected]>
GVodyanov
added
enhancement
2. developing
skill:frontend
Issues and PRs that require JavaScript/Vue/styling development skills
labels
Sep 12, 2024
Signed-off-by: Grigory V <[email protected]>
Signed-off-by: Grigory V <[email protected]>
Signed-off-by: Grigory V <[email protected]>
GVodyanov
force-pushed
the
feat/migrate-main-store-pinia
branch
from
September 17, 2024 08:01
18396da
to
b8e63c1
Compare
Signed-off-by: Grigory V <[email protected]>
Signed-off-by: Grigory V <[email protected]>
GVodyanov
force-pushed
the
feat/migrate-main-store-pinia
branch
from
September 17, 2024 13:51
76a519f
to
78247eb
Compare
Signed-off-by: Grigory V <[email protected]>
GVodyanov
force-pushed
the
feat/migrate-main-store-pinia
branch
from
September 17, 2024 14:51
78247eb
to
117f534
Compare
Signed-off-by: Grigory V <[email protected]>
Signed-off-by: Grigory V <[email protected]>
…dn't work if not Signed-off-by: Grigory V <[email protected]>
…ile, didn't work if not Signed-off-by: Grigory V <[email protected]>
Signed-off-by: Grigory Vodyanov <[email protected]>
Signed-off-by: Grigory Vodyanov <[email protected]>
Signed-off-by: Grigory Vodyanov <[email protected]>
Signed-off-by: Grigory Vodyanov <[email protected]>
Not opening the PR yet as I still have the tests to migrate, but mail is useable (as far as it seems) |
Signed-off-by: Grigory Vodyanov <[email protected]>
Signed-off-by: Grigory Vodyanov <[email protected]>
Signed-off-by: Grigory Vodyanov <[email protected]>
Signed-off-by: Grigory V <[email protected]>
Signed-off-by: Grigory Vodyanov <[email protected]>
Signed-off-by: Grigory Vodyanov <[email protected]>
Signed-off-by: Grigory Vodyanov <[email protected]>
Thanks so much for finishing the hardest parts Richard <3 |
GVodyanov
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
October 10, 2024 14:13
GVodyanov
requested review from
hamza221 and
ChristophWurst
and removed request for
ChristophWurst,
kesselb and
GretaD
October 10, 2024 14:13
needs a rebase, I wish you luck 🍀 |
kesselb
previously requested changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be merged after branch off for stable4.1
Let's get this in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
enhancement
skill:frontend
Issues and PRs that require JavaScript/Vue/styling development skills
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9237
This is going to be a big one...
Splitting stores into multiple files isn't very common in Pinia, but I really wanted to do so in this case, I took my inspiration for how to do it from these guys vuejs/pinia#802
A little overview of how this was done:
/store
for all the main mail store stuff[previous name]
+Mutation
dispatch
andcommit
usages in components to the correct Pinia usage