Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: phishing warning layout #10104

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix: phishing warning layout #10104

merged 1 commit into from
Sep 9, 2024

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Sep 5, 2024

b a
image image

@hamza221 hamza221 added bug 3. to review skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills labels Sep 5, 2024
@hamza221 hamza221 self-assigned this Sep 5, 2024
marcoambrosini
marcoambrosini reviewed Sep 6, 2024
View reviewed changes
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a is more appropriate but to be consistent with how we show warnings and info boxes, I would also add a calc(var(--default-grid-baseline) * 2) margin

marcoambrosini
marcoambrosini reviewed Sep 6, 2024
View reviewed changes
src/components/PhishingWarning.vue Outdated Show resolved Hide resolved
src/components/PhishingWarning.vue Outdated Show resolved Hide resolved
@hamza221
fix: phishing warning layout
2867a68 
Signed-off-by: Hamza Mahjoubi <[email protected]>
@hamza221 hamza221 force-pushed the fix/phishing-warning-ui branch from 8ff4340 to 2867a68 Compare September 9, 2024 08:22
@hamza221 hamza221 enabled auto-merge September 9, 2024 08:25
@hamza221 hamza221 merged commit 057d47b into main Sep 9, 2024
32 checks passed
@hamza221 hamza221 deleted the fix/phishing-warning-ui branch September 9, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb approved these changes

@GVodyanov GVodyanov Awaiting requested review from GVodyanov

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

@GretaD GretaD Awaiting requested review from GretaD GretaD is a code owner

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@hamza221 hamza221

Labels
3. to review bug skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hamza221 @kesselb @marcoambrosini