fix: handle missing email in contact check

Signed-off-by: Hamza Mahjoubi <[email protected]>
nextcloud · Aug 15, 2024 · eb11824 · eb11824
1 parent b881dd9
commit eb11824
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/Service/ContactsIntegration.php b/lib/Service/ContactsIntegration.php
@@ -236,7 +236,7 @@ private function doSearch(string $term, array $fields, bool $strictSearch, bool
 			}
 			$id = $r['UID'];
 			$fn = $r['FN'];
-			$email = $r['EMAIL'];
+			$email = $r['EMAIL'] ?? null;
 			$matches[] = [
 				'id' => $id,
 				'label' => $fn,

diff --git a/lib/Service/PhishingDetection/ContactCheck.php b/lib/Service/PhishingDetection/ContactCheck.php
@@ -23,6 +23,9 @@ public function run(string $fn, string $email): PhishingDetectionResult {
 		$emails = [];
 		$contacts = $this->contactIntegration->getContactsWithName($fn, true);
 		foreach ($contacts as $contact) {
+			if(!isset($contact['email'])) {
+				continue;
+			}
 			foreach ($contact['email'] as $contactEmail) {
 				$emails[] = $contactEmail;
 				if (strcasecmp($contactEmail, $email) == 0) {