Merge pull request #9424 from nextcloud/fix/db/dirty-read-local-messa…

…ge-update fix(db): Avoid dirty read for local message updates
nextcloud · Mar 5, 2024 · 6827296 · 6827296
2 parents 9a7e782 + fff840a
commit 6827296
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/Db/LocalMessageMapper.php b/lib/Db/LocalMessageMapper.php
@@ -256,14 +256,14 @@ public function updateWithRecipients(LocalMessage $message, array $to, array $cc
 			$message = $this->update($message);
 
 			$this->recipientMapper->updateRecipients($message->getId(), $message->getRecipients(), $to, $cc, $bcc);
+			$recipients = $this->recipientMapper->findByLocalMessageId($message->getId());
+			$message->setRecipients($recipients);
 			$this->db->commit();
+			return $message;
 		} catch (Throwable $e) {
 			$this->db->rollBack();
 			throw $e;
 		}
-		$recipients = $this->recipientMapper->findByLocalMessageId($message->getId());
-		$message->setRecipients($recipients);
-		return $message;
 	}
 
 	public function deleteWithRecipients(LocalMessage $message): void {

diff --git a/tests/Integration/Db/LocalMessageMapperTest.php b/tests/Integration/Db/LocalMessageMapperTest.php
@@ -174,7 +174,7 @@ public function testSaveWithRecipient(): void {
 		$this->assertCount(1, $row->getRecipients());
 	}
 
-	public function testUpdateWithRecipient(): void {
+	public function testUpdateWithRecipients(): void {
 		$results = $this->mapper->getAllForUser($this->account->getUserId());
 		$this->assertEmpty($results[0]->getRecipients());
 		// cleanup