fixup! Feat: link checking for phishing detection

Signed-off-by: Hamza Mahjoubi <[email protected]>
nextcloud · Aug 13, 2024 · 37da2be · 37da2be
1 parent 218d3da
commit 37da2be
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/tests/Integration/Service/Phishing/PhishingDetectionServiceIntegrationTest.php b/tests/Integration/Service/Phishing/PhishingDetectionServiceIntegrationTest.php
@@ -14,6 +14,7 @@
 use OCA\Mail\Service\PhishingDetection\ContactCheck;
 use OCA\Mail\Service\PhishingDetection\CustomEmailCheck;
 use OCA\Mail\Service\PhishingDetection\DateCheck;
+use OCA\Mail\Service\PhishingDetection\LinkCheck;
 use OCA\Mail\Service\PhishingDetection\PhishingDetectionService;
 use OCA\Mail\Service\PhishingDetection\ReplyToCheck;
 use OCP\AppFramework\Utility\ITimeFactory;
@@ -30,6 +31,7 @@ class PhishingDetectionServiceIntegrationTest extends TestCase {
 	private CustomEmailCheck $customEmailCheck;
 	private DateCheck $dateCheck;
 	private ReplyToCheck $replyToCheck;
+	private LinkCheck $linkCheck;
 	private PhishingDetectionService $service;
 
 	protected function setUp(): void {
@@ -40,7 +42,8 @@ protected function setUp(): void {
 		$this->customEmailCheck = new CustomEmailCheck($this->l10n);
 		$this->dateCheck = new DateCheck($this->l10n, \OC::$server->get(ITimeFactory::class));
 		$this->replyToCheck = new ReplyToCheck($this->l10n);
-		$this->service = new PhishingDetectionService($this->contactCheck, $this->customEmailCheck, $this->dateCheck, $this->replyToCheck);
+		$this->linkCheck = new LinkCheck($this->l10n);
+		$this->service = new PhishingDetectionService($this->contactCheck, $this->customEmailCheck, $this->dateCheck, $this->replyToCheck, $this->linkCheck);
 	}
 
 

diff --git a/tests/Unit/Service/Phishing/PhishingDetectionServiceTest.php b/tests/Unit/Service/Phishing/PhishingDetectionServiceTest.php
@@ -13,6 +13,7 @@
 use OCA\Mail\Service\PhishingDetection\ContactCheck;
 use OCA\Mail\Service\PhishingDetection\CustomEmailCheck;
 use OCA\Mail\Service\PhishingDetection\DateCheck;
+use OCA\Mail\Service\PhishingDetection\LinkCheck;
 use OCA\Mail\Service\PhishingDetection\PhishingDetectionService;
 use OCA\Mail\Service\PhishingDetection\ReplyToCheck;
 
@@ -24,6 +25,7 @@ class PhishingDetectionServiceTest extends TestCase {
 	private CustomEmailCheck|MockObject $customEmailCheck;
 	private DateCheck|MockObject $dateCheck;
 	private ReplyToCheck|MockObject $replyToCheck;
+	private LinkCheck|MockObject $linkCheck;
 	private PhishingDetectionService $service;
 
 	protected function setUp(): void {
@@ -32,7 +34,8 @@ protected function setUp(): void {
 		$this->customEmailCheck = $this->createMock(customEmailCheck::class);
 		$this->dateCheck = $this->createMock(DateCheck::class);
 		$this->replyToCheck = $this->createMock(ReplyToCheck::class);
-		$this->service = new PhishingDetectionService($this->contactCheck, $this->customEmailCheck, $this->dateCheck, $this->replyToCheck);
+		$this->linkCheck = $this->createMock(LinkCheck::class);
+		$this->service = new PhishingDetectionService($this->contactCheck, $this->customEmailCheck, $this->dateCheck, $this->replyToCheck, $this->linkCheck);
 	}
 
 
@@ -56,7 +59,10 @@ public function testCheckHeadersForPhishing(): void {
 		$this->customEmailCheck->expects($this->once())
 			->method('run')
 			->willReturn(new PhishingDetectionResult(PhishingDetectionResult::CUSTOM_EMAIL_CHECK, false));
-		$result = $this->service->checkHeadersForPhishing($parsedHeaders, false);
+		$this->linkCheck->expects($this->once())
+			->method('run')
+			->willReturn(new PhishingDetectionResult(PhishingDetectionResult::LINK_CHECK, false));
+		$result = $this->service->checkHeadersForPhishing($parsedHeaders, true, '');
 		$this->assertFalse($result["warning"]);
 	}