fixup! perf: reduce number of avatar requests

Signed-off-by: Hamza Mahjoubi <[email protected]>

lib/Contracts/IMailSearch.php

@@ -36,6 +36,7 @@ public function findMessage(Account $account,
 	 * @param string|null $filter
 	 * @param int|null $cursor
 	 * @param int|null $limit
+	 * @param string|null $userId
 	 *
 	 * @return Message[]
 	 *
@@ -47,7 +48,8 @@ public function findMessages(Account $account,
 		string $sortOrder,
 		?string $filter,
 		?int $cursor,
-		?int $limit): array;
+		?int $limit,
+		?string $userId): array;
 
 	/**
 	 * @param IUser $user

lib/Controller/MessagesController.php

@@ -152,7 +152,8 @@ public function index(int $mailboxId,
 				$order,
 				$filter === '' ? null : $filter,
 				$cursor,
-				$limit
+				$limit,
+				$this->currentUserId
 			)
 		);
 	}

lib/IMAP/PreviewEnhancer.php

@@ -38,29 +38,24 @@ class PreviewEnhancer {
 	/** @var AvatarService */
 	private $avatarService;
 
-	/** @var string|null */
-	private $userId;
-
 	public function __construct(IMAPClientFactory $clientFactory,
 		ImapMapper $imapMapper,
 		DbMapper $dbMapper,
 		LoggerInterface $logger,
-		AvatarService $avatarService,
-		string $userId) {
+		AvatarService $avatarService) {
 		$this->clientFactory = $clientFactory;
 		$this->imapMapper = $imapMapper;
 		$this->mapper = $dbMapper;
 		$this->logger = $logger;
 		$this->avatarService = $avatarService;
-		$this->userId = $userId;
 	}
 
 	/**
 	 * @param Message[] $messages
 	 *
 	 * @return Message[]
 	 */
-	public function process(Account $account, Mailbox $mailbox, array $messages, string $mode = 'sync'): array {
+	public function process(Account $account, Mailbox $mailbox, array $messages, bool $preLoadAvatars = false, ?string $userId): array {
 		$needAnalyze = array_reduce($messages, static function (array $carry, Message $message) {
 			if ($message->getStructureAnalyzed()) {
 				// Nothing to do
@@ -70,12 +65,11 @@ public function process(Account $account, Mailbox $mailbox, array $messages, str
 			return array_merge($carry, [$message->getUid()]);
 		}, []);
 
-		// If we are in the API call, we need to fetch the avatar for the sender
-		if ($mode === 'apiCall') {
+		if ($preLoadAvatars) {
 			foreach ($messages as $message) {
-				$from = $message->getFrom()->first() ;
-				if ($message->getAvatar() === null && $from !== null && $from->getEmail() !== null && $this->userId !== null) {
-					$avatar = $this->avatarService->getAvatar($from->getEmail(), $this->userId);
+				$from = $message->getFrom()->first();
+				if ($message->getAvatar() === null && $from !== null && $from->getEmail() !== null && $userId !== null) {
+					$avatar = $this->avatarService->getAvatar($from->getEmail(), $userId, true);
 					$message->setAvatar($avatar);
 				}
 			}

lib/Service/AvatarService.php

@@ -91,12 +91,12 @@ private function hasAllowedMime(Avatar $avatar): bool {
 	 * @param string $uid
 	 * @return Avatar|null
 	 */
-	public function getAvatar(string $email, string $uid): ?Avatar {
+	public function getAvatar(string $email, string $uid, bool $cachedOnly = false): ?Avatar {
 		$cachedAvatar = $this->cache->get($email, $uid);
 		if ($cachedAvatar) {
 			return $cachedAvatar;
 		}
-		if ($cachedAvatar === false) {
+		if ($cachedAvatar === false || $cachedOnly) {
 			// We know there is no avatar
 			return null;
 		}

lib/Service/Search/MailSearch.php

@@ -91,7 +91,8 @@ public function findMessages(Account $account,
 		string $sortOrder,
 		?string $filter,
 		?int $cursor,
-		?int $limit): array {
+		?int $limit,
+		?string $userId): array {
 		if ($mailbox->hasLocks($this->timeFactory->getTime())) {
 			throw MailboxLockedException::from($mailbox);
 		}
@@ -119,7 +120,8 @@ public function findMessages(Account $account,
 				$this->getIdsLocally($account, $mailbox, $query, $sortOrder, $limit),
 				$sortOrder,
 			),
-			'apiCall'
+			true,
+			$userId
 		);
 	}
 

src/components/Avatar.vue

@@ -18,6 +18,7 @@
 <script>
 import NcAvatar from '@nextcloud/vue/dist/Components/NcAvatar.js'
 import { generateUrl } from '@nextcloud/router'
+import { fetchAvatarUrlMemoized } from '../service/AvatarService.js'
 import logger from '../logger.js'
 
 export default {
@@ -65,8 +66,15 @@ export default {
 					email: this.email,
 				})
 				: this.avatar.url
+		} else {
+			if (this.email !== '') {
+				try {
+					this.avatarUrl = await fetchAvatarUrlMemoized(this.email)
+				} catch {
+					logger.debug('Could not fetch avatar', { email: this.email })
+				}
+			}
 		}
-		logger.debug('Could not fetch avatar', { email: this.email })
 		this.loading = false
 	},
 }