-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fallback if searchresult contains error on initial query #359
base: master
Are you sure you want to change the base?
Conversation
I like the idea of switching on error, but not a fan of doing a test request. Also, it needs to be implemented in files_fulltextsearch instead. I will have a look during the conf/hackweek |
@daita We can discuss it in person then! ;) |
Sure ! this is the whole interest of the conf ! in the meanwhile: So, if you create a |
} | ||
self.removeOldSearchbox(); | ||
}).fail(function () { | ||
console.log("the searchrequest failed! Reload page."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.log("the searchrequest failed! Reload page."); | |
console.log("the search request failed! Reload the page."); |
} | ||
}).done(function (res) { | ||
if (_.has(res, 'error')) { | ||
console.log("there was an error with the search! Contact admin."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.log("there was an error with the search! Contact admin."); | |
console.log("there was an error with the search! Contact an admin."); |
Implements #353