-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nextcloud: add apache container reachability check run-exec-commands.sh #5730
Conversation
…nds.sh Signed-off-by: JMarcosHP <[email protected]>
Signed-off-by: Jehu Marcos Herrera Puentes <[email protected]>
Signed-off-by: Jehu Marcos Herrera Puentes <[email protected]>
Hey, thanks a lot for the PR! :) However I would prefer a solution where we wait for the apache container to be available and then run the command directly. |
Sure! We can do this, but we need to add 2 environment variables to the nextcloud container, |
Currently we only have $APACHE_PORT inside the container. I don't know where the nextcloud container gets these values or how to add the $APACHE_HOST env variable to get it working.
Edit: I figured how to add it, in the containers.json file. |
…vor of apache container host. Signed-off-by: JMarcosHP <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @JMarcosHP! 😊
This is now released with v10.2.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel |
Closes #5722