DockerActionManager: improve PullImage to always log something if it fails #5673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fails Signed-off-by: Simon L. <[email protected]>
szaimen
added
3. to review
41 tasks
docjyJ
reviewed
Nov 28, 2024
| if ($imageIsThere === false) { | ||
| throw new \Exception("Could not pull image " . $imageName . ". Please run 'sudo docker exec -it nextcloud-aio-mastercontainer docker pull " . $imageName . "' in order to find out why it failed."); | ||
| throw new \Exception($message); |
There was a problem hiding this comment.
Suggested change
| throw new \Exception($message); | |
| throw new AioException($message, previous: $e); |
Idea:
- Create an AioExetion class
- Use the previous argument to help debugging
There was a problem hiding this comment.
Thanks for the idea but lets do this in a follow-up! :)
|
Thanks dor the review @docjyJ :) |
|
This is now released with v10.1.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.