Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to exclude previews from restore upon instance restore #5550

Merged
merged 2 commits into from
Nov 12, 2024
Merged

allow to exclude previews from restore upon instance restore #5550

merged 2 commits into from
Nov 12, 2024

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Nov 8, 2024

Close #5451

@szaimen szaimen added 2. developing Work in progress enhancement New feature or request borg labels Nov 8, 2024
@szaimen szaimen added this to the next milestone Nov 8, 2024
@szaimen szaimen requested review from timdiels and ernolf November 8, 2024 10:10
@szaimen szaimen mentioned this pull request Nov 8, 2024
Closed
29 tasks
@szaimen
Copy link
Collaborator Author

szaimen commented Nov 8, 2024

@timdiels can you please have a look how to achieve the same for remote backups?
Thanks in advance! :)

@szaimen szaimen force-pushed the enh/5451/exclude-previews branch from 73b944f to cfbfc58 Compare November 8, 2024 10:13
@szaimen szaimen changed the title aio-interface: allow to exclude previews from restore upon instance restore allow to exclude previews from restore upon instance restore Nov 8, 2024
@szaimen szaimen force-pushed the enh/5451/exclude-previews branch 2 times, most recently from 29ea672 to a241375 Compare November 8, 2024 10:23
@timdiels
Copy link
Collaborator

timdiels commented Nov 8, 2024

@szaimen I'll have a look Sunday. Do you want me to add it to this PR?

@szaimen
Copy link
Collaborator Author

szaimen commented Nov 8, 2024

@szaimen I'll have a look Sunday.

Thanks!

Do you want me to add it to this PR?

Yes please :)

@timdiels
Copy link
Collaborator

Tested the remote case with and without preview locally. Works for me

timdiels
timdiels approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@timdiels timdiels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes LGTM but someone should still have a look at mine

@szaimen szaimen force-pushed the enh/5451/exclude-previews branch from 2f1aed0 to af3f00c Compare November 12, 2024 11:16
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 12, 2024
@szaimen szaimen merged commit dc5a540 into main Nov 12, 2024
10 checks passed
@szaimen szaimen deleted the enh/5451/exclude-previews branch November 12, 2024 11:17
@szaimen
Copy link
Collaborator Author

szaimen commented Nov 12, 2024

This is now released with v10.0.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdiels timdiels timdiels approved these changes

@ernolf ernolf Awaiting requested review from ernolf

Assignees
No one assigned
Labels
3. to review Waiting for reviews borg enhancement New feature or request
Projects
None yet
Milestone
v10.0.0
Development

Successfully merging this pull request may close these issues.

allow to exclude previews from restore upon instance restore
2 participants
@szaimen @timdiels