docker-socket-proxy: move installation of app_api to containers.json … #5062
Conversation
…and nextcloud_exec_commands Signed-off-by: Simon L. <[email protected]>
szaimen
added
3. to review
| php /var/www/html/occ app:update app_api | ||
| fi | ||
| else | ||
| if [ "$REMOVE_DISABLED_APPS" = yes ] && [ -d "/var/www/html/custom_apps/app_api" ]; then | ||
| php /var/www/html/occ app:remove app_api |
There was a problem hiding this comment.
I don't think this is a problem, but the update and delete functionality is not offered by nextcloud_exec_commands.
There was a problem hiding this comment.
With the addition of this option, it would be possible to manage the required applications more precisely.
containers-schema.json
"nextcloud_applications": {
"type": "array",
"items": {
"type": "string",
"pattern": "^\\w+$"
}
},If you think it might be good, I can add installation and activation with this option.
There was a problem hiding this comment.
... and delete functionality is not offered by nextcloud_exec_commands.
ah good point. that is why I didnt use it for that in the past. Thanks for reminding me :)
If you think it might be good, I can add installation and activation with this option.
I think this is a big overengineered for now but thanks for the idea :)
|
Thanks! I'm working on Stalwart and the 9.0 update. I just deployed my AIO instance on the RK3588, and I'll be migrating to Stalwart soon. Maybe add a way to edit the default configuration (eg: use your own certificate, use another subdomain...). It would be nice to have a perfect solution for beginners but powerful for advanced users (at their own risk). |
|
Also do you have some time to take a look at the aio-stalwart PRs? It's good to have feedback, especially from someone with experience. |
all right, cool
This could be done with a CC like the caddy container but will not be added for the AIOs default caddy one, mostly due to maintainability concerns.
This is fine with CCs but not for the default stack. Since adding options will also compllicate things for beginners.
What exactly do you want me to look into there? |
I was thinking about a file to rewrite default rules. Especially to use a custom proxy (instead of Caddy CC) or use a custom domain. This is the only thing that the container manages with admin IDs and logs.
Just to review these features. By asking for review via github feature. If you agree. |
Hm... can you describe your use case a bit more in detail? So basically please point out why you would need this?
I can probably review changes on github that you do but I cannot test updates for stalwart unfortunately since my test instance does not allow to test stalwart because I am unfortunately not in control over the dns confguration that the server uses... |
|
Here example of my idea : https://github.com/docjyJ/aio-stalwart/blob/dev/manager/start.sh Users can decide to disable some logics if they prefer to manage by themselves. Some use cases I see:
In the future, it could allow creating a Nextcloud / Stalwart user synchronization by simply activating a line in a file. |
|
I see, looks interesting! Do you have an example how a user would adjust these settings? Going into the container and then adjusting the settings in a file for example? |
|
It would be in a file skip-secure-check = false
manage.binding.mail = true
manage.binding.caddy-web = true
manage.storage.data = true
manage.storage.directory = true
manage.log.file = true
manage.log.stdout = true
manage.admin = true
manage.certificate = true |
|
Looks cool! I mean if you want to add and support this, in your stalwart container feel free to! :) |
|
Anotjer option would be to add an env file that gets sourced inside start.sh into the volume. Then you dont need a custom logic for getting and setting env. Wdyt about this idea? |
|
Yes, maybe better |
…and nextcloud_exec_commands