Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm - add livenessprobe to apache #3807

Closed
wants to merge 1 commit into from
Closed

helm - add livenessprobe to apache #3807

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions nextcloud-aio-helm-chart/templates/nextcloud-aio-apache-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,13 @@ spec:
protocol: TCP
- containerPort: {{ .Values.APACHE_PORT }}
protocol: UDP
livenessProbe:
exec:
command:
- bash
- /healthcheck.sh
failureThreshold: 1
periodSeconds: 10
Comment on lines +67 to +73
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be added via script. and I guess it will not work yet due to

all-in-one/Containers/apache/healthcheck.sh

Line 3 in a43f755

nc -z "$NEXTCLOUD_HOST" 9000 || exit 0
which is exactly what we want to catch here...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I wonder if we would basically need liveness probes for all containers so that they get restarted if some other container got missing in the meantime...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another solution would be to put everything into one pod but doesnt sound like the best solution either...

volumeMounts:
- mountPath: /var/www/html
name: nextcloud-aio-nextcloud
Expand Down