test if hostname makes it work #3788
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
force-pushed
the
enh/noid/add-hostname
branch
3 times, most recently
from
cdd20b8 to
31d13bc
Compare
Signed-off-by: Simon L <[email protected]> Revert "test if hostname makes it work" This reverts commit 31d13bc. use nc_domain as service name Signed-off-by: Simon L <[email protected]>
szaimen
force-pushed
the
enh/noid/add-hostname
branch
from
31d13bc to
390ed1f
Compare
st3iny
requested changes
Nov 21, 2023
There was a problem hiding this comment.
Kubernetes complains when installing the manifest: Error: UPGRADE FAILED: failed to create resource: Service "no-domain.com" is invalid: metadata.name: Invalid value: "no-domain.com": a DNS-1035 label must consist of lower case alphanumeric characters or '-', start with an alphabetic character, and end with an alphanumeric character (e.g. 'my-name', or 'abc-123', regex used for validation is '[a-z]([-a-z0-9]*[a-z0-9])?')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.